{{Quickfixn}} ClientHandlerThread Debug Logging

[Campbell Wild]

Yes, yes, yes!!!
________________________________
From: Quickfixn <quickfixn-bounces at lists.quickfixn.com> on behalf of James Coverdale <jcoverdale at redev.co.uk>
Sent: 09 September 2021 09:12
To: quickfixn at lists.quickfixn.com <quickfixn at lists.quickfixn.com>
Subject: {{Quickfixn}} ClientHandlerThread Debug Logging

[CAUTION] EXTERNAL EMAIL ..


Hi,



We have run into issues with large numbers of ‘ClientHandlerThread’ debug logs being created, seems that other people have had the same issue: https://github.com/connamara/quickfixn/issues/684<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fconnamara%2Fquickfixn%2Fissues%2F684&data=04%7C01%7CCampbell.Wild%40ihsmarkit.com%7C57551dd91def47819c0208d97369a8ed%7Cc1156c2fa3bb4fc4ac073eab96da8d10%7C0%7C0%7C637667720480735410%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=6cV82G7uMhe9Yk3jN%2Bx90QLDdwhQGEvBnA8n6aYCPog%3D&reserved=0>



It doesn’t seem like a major change to add a config bool to have the ability to turn these ‘debug’ logs off in production environments? Update ClientHandlerThread.cs to use an ILOG for the ‘log_’ and a NullLogger if the new config bool is set.



I can create a PR, but wanted to run the idea past people first.



Thanks,

James.





________________________________

This e-mail, including accompanying communications and attachments, is strictly confidential and only for the intended recipient. Any retention, use or disclosure not expressly authorised by IHSMarkit is prohibited. This email is subject to all waivers and other terms at the following link: https://ihsmarkit.com/Legal/EmailDisclaimer.html

Please visit www.ihsmarkit.com/about/contact-us.html for contact information on our offices worldwide.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.quickfixn.com/pipermail/quickfixn-quickfixn.com/attachments/20210909/d21ab05c/attachment.htm>