<div dir="ltr"><div class="gmail_default" style="font-size:small;color:#000000">Me and Mike were talking a little yesterday about this and also broader QF/n issues.</div><div class="gmail_default" style="font-size:small;color:#000000"><br></div><div class="gmail_default" style="font-size:small;color:#000000">There's a lot of things in the code that are just not very awesome. Such as:</div><div class="gmail_default" style="font-size:small;color:#000000"><ul><li>Overcomplex code</li><li>Unnecessary duplication</li><li>Crazy code flow between Session and Initiator/Acceptor</li><li>Lots of un-C#-like things (get/set functions instead of properties, lower-cased functions)</li><li>Many public things that should not be public</li><li>Terrible logging</li></ul><div>I'm starting to wonder if it's time for a 2.0. The need for backward compatibility is starting to feel like a straightjacket, and our velocity is zero. It'd be refreshing if we could be a little reckless for a while.</div><div><br></div><div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 5, 2014 at 8:54 AM, Mike Gatny <span dir="ltr"><<a href="mailto:mgatny@connamara.com" target="_blank">mgatny@connamara.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Staffan,<div><br></div><div>We welcome all patches -- contribution guidelines are here:</div><div><br></div><div><a href="https://github.com/connamara/quickfixn/wiki/Contributor-FAQ" target="_blank">https://github.com/connamara/quickfixn/wiki/Contributor-FAQ</a></div><div><br></div><div>Pull requests are definitely preferred (and there's at least one github issue filed for this problem already).</div><div><br></div><div>Regarding the multi-byte character issue, we'd definitely like to solve that problem once and for all. From a FIX specification standpoint, non-ascii encoding is only allowed in certain special "Encoded" fields. In reality, many major FIX counterparties violate this. Further confusing that point is the fact that quickfix/j (possibly entirely by coincidence since java Strings are UTF-16) works fine with non-ascii encodings. So, I think quickfix/n is in a similar position that web browsers found themselves in: there is a standard, but there may actually be more people violating it than actually conforming to it. The web browser solution to this is to operate in "standards mode" or "quirks mode" as needed, and that is probably not a bad way to go about it. I.e. it's a bit too late to insist that everyone encode FIX as ascii per the standard.</div><div><br></div><div>If you don't mind re-working your patch as a github pull request, we can move the review/discussion of it there. Thanks!</div><div><br></div><div>Regarding your comments on places where refactoring is needed or performance could be tuned, you are certainly correct. We've gotten QF/n to the point where it is a nearly complete port of QF/j and QF/c++, but we have not yet gone back and done any major refactoring or performance profiling. Any help in that area would be greatly appreciated -- there should be plenty of low-hanging fruit!</div><div><br></div><div>Thanks,</div><div><span style="font-family:arial,helvetica,sans-serif">--</span><br></div><div class="gmail_extra"><div><div dir="ltr"><font face="arial, helvetica, sans-serif">Mike Gatny<br>Connamara Systems, LLC</font></div><div dir="ltr"><br></div></div></div></div>
<br>_______________________________________________<br>
Quickfixn mailing list<br>
<a href="mailto:Quickfixn@lists.quickfixn.com">Quickfixn@lists.quickfixn.com</a><br>
<a href="http://lists.quickfixn.com/listinfo.cgi/quickfixn-quickfixn.com" target="_blank">http://lists.quickfixn.com/listinfo.cgi/quickfixn-quickfixn.com</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div><font><span style="background-color:#000000"><span style="background-color:#ffffff">Grant Birchmeier</span></span></font><font><font color="#3333ff"><br></font></font></div><div><font><b><font color="#3333ff"><span style="background-color:#ffcc33"><span style="background-color:#ffcc66"><span style="background-color:#ffcc99"><span style="background-color:#ffffff"><span style="background-color:#ffcc00">Connamara Systems, LLC</span></span></span></span></span></font></b></font><br></div><div><font><b>Made-To-Measure Trading Solutions.</b></font></div><div><font>Exactly what you need. No more. No less.</font><font><b><font color="#3333ff"><br></font></b></font></div><div><font><a href="http://connamara.com" target="_blank">http://connamara.com</a><br></font></div></div>
</div>