<div><font color="#000000"><font>The proper procedure is to create a github fork and then submit a pull request with your fix. Please make sure all existing tests pass and that your code has tests that confirm that it does what it is supposed to do. After review, we will merge it into the mainline. Let me know if you have any questions.<br>
</font></font></div><div><font color="#000000"><font><br></font></font></div><div><font color="#000000"><font>Regarding this specific fix, OrigSendingTime isn't marked as required in the DD. Where in the QF/n source is the rejection beign triggered? I think I agree that a missing OrigSendingTime shouldn't always cause the message to be rejected. I assume your fix implements a new Config setting?</font></font></div>
<div><font color="#000000"><font><br></font></font></div><div><font color="#000000"><font>Perhaps the most key question now is whether the default config should be to reject or not reject.<br></font></font></div><div><font color="#000000"><font><br>
</font></font></div><div><font color="#000000"><font><br></font></font></div><br><div class="gmail_quote">On Thu, Sep 6, 2012 at 9:28 AM, Thomas Fleming <span dir="ltr"><<a href="mailto:thomas.fleming@sucfin.com" target="_blank">thomas.fleming@sucfin.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-GB" link="blue" vlink="blue">
<div>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">Having gone away and done some more research on this, the general consensus is that whilst OrigSendingTime is technically required by
the FIX Session Spec, it is not logical for it to be required and should therefore not be a mandatory field. See
<a href="http://fixprotocol.org/discuss/read/ae47f2f5" target="_blank">http://fixprotocol.org/discuss/read/ae47f2f5</a> for a better discussion.</span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">I have coded a work around in Session.cs, effectively a property that sets whether this field should be required or not for SequenceReset
messages, and an if statement in DoPossDup(Message msg).</span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">This seems to be a common issue, therefore I believe this workaround should be available in QuickFIX/n. Would anyone have an issue with
me checking this in to the main repository?</span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">Tom</span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<div>
<div class="MsoNormal" align="center" style="text-align:center"><font size="3" face="Times New Roman"><span lang="EN-US" style="font-size:12.0pt">
<hr size="2" width="100%" align="center">
</span></font></div>
<p class="MsoNormal"><b><font face="Tahoma"><span lang="EN-US" style="font-size:10.0pt;font-family:Tahoma;font-weight:bold">From:</span></font></b><font face="Tahoma"><span lang="EN-US" style="font-size:10.0pt;font-family:Tahoma"> <a href="mailto:quickfixn-bounces@lists.quickfixn.com" target="_blank">quickfixn-bounces@lists.quickfixn.com</a>
[mailto:<a href="mailto:quickfixn-bounces@lists.quickfixn.com" target="_blank">quickfixn-bounces@lists.quickfixn.com</a>] <b><span style="font-weight:bold">On Behalf Of
</span></b>Thomas Fleming<br>
<b><span style="font-weight:bold">Sent:</span></b> 04 September 2012 16:45</span></font></p><div class="im"><font face="Tahoma"><br>
<b><span style="font-weight:bold">To:</span></b> 'Mailing list for QuickFIX/n'<br>
<b><span style="font-weight:bold">Subject:</span></b> Re: {{Quickfixn}} Possible bug in QuickFIX/n?</font></div>
</div>
<p class="MsoNormal"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"> </span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">I have just had a look at the “Sessions Protocol Specification” available at
<a href="http://fixprotocol.org/documents/3070/FIX_Transport_1.1.pdf" target="_blank">http://fixprotocol.org/documents/3070/FIX_Transport_1.1.pdf</a>. I can’t see anything that says it isn’t required for admin messages.</span></font></p>
<div class="im">
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">The pdf has a test section titled “Test cases applicable to all FIX systems”. Test “g” is as follows:</span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">Condition/Stimulus: PossDupFlag set to Y and OrigSendingTime not specified.</span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">Expected Behaviour: Send Reject (session-level) message referencing missing OrigSendingTime (>= FIX 4.2:SessionRejectReason = “Required
tag missing”). Increment inbound MsgSeqNum.</span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">This is what QuickFIX/n presently does.</span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">The only other slightly relevant info is that BARX are sending a Sequence Reset (Gap Fill) message i.e. Field 123=Y in the SequenceReset
message. This still doesn’t seem to change the fact that OrigSendingTime is required.</span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">Tom, how did you resolve your issue with TT? Barx are suggesting that we use ValidateIncomingMessage=N, but this would disable all validation,
not just for the SequenceReset message. Obviously we do not want to do that.</span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">Regards, Tom</span></font>
</p>
</div></div>
<font>
<p align="left"><span lang="EN-US" style="FONT-SIZE:10pt;BACKGROUND:white"><a href="http://www.sucdenfinancial.com/" target="_blank">www.sucdenfinancial.com</a></span></p></font><div class="im">
<p align="left"><font face="Arial, Helvetica, sans-serif"><span lang="EN-US" style="FONT-SIZE:10pt;BACKGROUND:white">Sucden Financial Limited, Plantation Place South, 60 Great Tower Street, London EC3R 5AZ<br>Telephone <a href="tel:%2B44%20203%20207%205000" value="+442032075000" target="_blank">+44 203 207 5000</a><br>
<br>Registered in England no. 1095841<br>VAT registration no. GB 446 9061 33</span></font></p>
<p align="left"><font face="Arial, Helvetica, sans-serif"><span lang="EN-US" style="FONT-SIZE:10pt;BACKGROUND:white">Authorised and Regulated by the Financial Services Authority (FSA) and entered in the FSA register under no. 114239<br>
<br></span></font><span style="FONT-SIZE:10pt"><font face="Arial, Helvetica, sans-serif">This email, including any files transmitted with it, is confidential and may be privileged. It may be read, copied and used only by the intended recipient. If you are not the intended recipient of this message, please notify <u><a href="mailto:postmaster@sucfin.com" target="_blank">postmaster@sucfin.com</a></u> immediately and delete it from your computer system.</font></span></p>
<p class="MsoNormal" style="MARGIN:0cm 0cm 0pt" align="left"><span style="FONT-SIZE:10pt"><font face="Arial, Helvetica, sans-serif">We believe, but do not warrant, that this email and its attachments are virus-free, but you should check.</font></span></p>
<p class="MsoNormal" style="MARGIN:0cm 0cm 0pt" align="left"> </p>
<p class="MsoNormal" style="MARGIN:0cm 0cm 0pt" align="left"><span style="FONT-SIZE:10pt"><font face="Arial, Helvetica, sans-serif">Sucden Financial Limited may monitor traffic data of both business and personal emails. By replying to this email, you consent to Sucden Financial 's monitoring the content of any emails you send to or receive from Sucden Financial . Sucden Financial is not liable for any opinions expressed by the sender where this is a non-business email.</font></span></p>
<p class="MsoNormal" style="MARGIN:0cm 0cm 0pt" align="left"> </p>
<p class="MsoNormal" style="MARGIN:0cm 0cm 0pt" align="left"><font face="Arial, Helvetica, sans-serif"><span lang="EN-US" style="FONT-SIZE:10pt;BACKGROUND:white">The contents of this e-mail do not constitute advice and should not be regarded as a recommendation to buy, sell or otherwise deal with any particular investment.</span></font></p>
<p class="MsoNormal" style="MARGIN:0cm 0cm 0pt" align="left"> </p>
<p class="MsoNormal" style="MARGIN:0cm 0cm 0pt" align="left"><font face="Arial, Helvetica, sans-serif"><span lang="EN-US" style="FONT-SIZE:10pt;BACKGROUND:white">This message has been scanned for viruses by </span><span lang="EN-US" style="FONT-SIZE:10pt"><a title="http://www.mimecast.com/" href="http://www.mimecast.com/" target="_blank"><span style="background:white">Mimecast</span></a></span></font></p>
</div></div>
<br>_______________________________________________<br>
Quickfixn mailing list<br>
<a href="mailto:Quickfixn@lists.quickfixn.com">Quickfixn@lists.quickfixn.com</a><br>
<a href="http://lists.quickfixn.com/listinfo.cgi/quickfixn-quickfixn.com" target="_blank">http://lists.quickfixn.com/listinfo.cgi/quickfixn-quickfixn.com</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div><font><span style="background-color:#000000"><span style="background-color:#ffffff">Grant Birchmeier</span></span></font><font><font color="#3333ff"><br></font></font></div>
<div><font><b><font color="#3333ff"><span style="background-color:#ffcc33"><span style="background-color:#ffcc66"><span style="background-color:#ffcc99"><span style="background-color:#ffffff"><span style="background-color:#ffcc00">Connamara Systems, LLC</span></span></span></span></span></font></b></font><br>
</div><div><font><b>Made-To-Measure Trading Solutions.</b></font></div><div><font>Exactly what you need. No more. No less.</font><font><b><font color="#3333ff"><br></font></b></font></div><div><font><a href="http://connamara.com" target="_blank">http://connamara.com</a><br>
</font></div><br>